[OE-core] [PATCH] acpica: Add ACPICA package

[Matt Ranostay]

On Wed, Aug 7, 2013 at 7:34 AM, Burton, Ross <ross.burton at intel.com> wrote:

> Hi,
>
> On 7 August 2013 15:17, Matt Ranostay <mranostay at gmail.com> wrote:
> > Added ACPICA package which enables viewing/editing/compiling
> > of ACPI tables.
>
> Is this really general-purpose enough to be suitable for oe-core, or
> would it be more suited to meta-oe or some other layer?
>
> Probably correct to be in meta-oe or another layer since only x86 and some
ARM platforms use ACPI as of now.


> > +PR = "r0"
>
> Remove this line, r0 is the default.
>
> +LIC_FILES_CHKSUM =
>
> "file://${S}/source/include/aclocal.h;endline=42;md5=07fbd4e514c75e140a19e3ab508f763d"
>
> ${S} is default, so in general people do file://sources/...
>
> > +SRC_URI = "
> https://acpica.org/sites/acpica/files/acpica-unix2-${PV}.tar.gz"
>
> Fetching that here with wget produces:
>
> ERROR: The certificate of ‘acpica.org’ is not trusted.
>
>
Seems StartCom Ltd. isn't a trusted  CA or just not in the keystore by
default.


> Someone should tell them...
>
> > +inherit autotools
>
> The recipe doesn't use autotools, so you should drop this inherit.
>
> > +do_install() {
> > +    oe_runmake INSTALLFLAGS="-m 555"
> > +}
>
> That's just running 'make INSTALLFLAGS="-m 555"'.  You'll need to tell
> it to run the right target for install, and to pass ${D} somehow so
> the makefile doesn't try and write to /usr directly.
>
> Gah good catch. Will fix up and resubmit.


> Ross
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20130807/b732effa/attachment-0002.html>