[OE-core] [PATCH 3/6] e2fsprogs: only update the icache for ext2_inode

Darren Hart dvhart at linux.intel.com
Fri Aug 23 17:03:09 UTC 2013


On Fri, 2013-08-23 at 09:58 +0800, Robert Yang wrote:
> On 08/23/2013 01:23 AM, Darren Hart wrote:
> > On Thu, 2013-08-22 at 09:13 -0400, Robert Yang wrote:
> >> We only read the cache when:
> >>
> >> bufsize == sizeof(struct ext2_inode)
> >>
> >> then we should only update the cache in the same condition, otherwise
> >> there would be errors, for example:
> >>
> >> cache[0]: cached ino 14 when bufsize = 128 by ext2fs_write_inode_full()
> >> cache[1]: cached ino 14 when bufsize = 156 by ext2fs_read_inode_full()
> >>
> >> Then update the cache:
> >> cache[0]: cached ino 15 when bufsize = 156 by ext2fs_read_inode_full()
> >>
> >> Then the ino 14 would hit the cache[1] when bufsize = 128 (but it was
> >> cached by bufsize = 156), so there would be errors.
> >
> >> [YOCTO #3848]
> >>
> >> Signed-off-by: Robert Yang <liezhi.yang at windriver.com>
> >
> >
> >> +Upstream-Status: [Inappropriate]
> >
> > Hrm... why is this one inappropriate?
> >
> 
> Hi Darren, the upstream has changed the icache lot, so this patch is
> inappropriate for the upstream, we can drop this patch when we update
> the package, I had put this in the patch head.

Sorry, I must have missed that.

Acked-by: Darren Hart <dvhart at linux.intel.com>

Thanks Robert!

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel





More information about the Openembedded-core mailing list