[OE-core] [PATCH] eglibc: Update SRC_URI and fix unpackaged empty dir

[Khem Raj]

On Aug 26, 2013, at 2:45 AM, Martin Jansa <martin.jansa at gmail.com> wrote:

> On Mon, Aug 26, 2013 at 12:37:18PM +0300, Riku Voipio wrote:
>> Hi,
>> 
>> On 21 August 2013 08:45, Khem Raj <raj.khem at gmail.com> wrote:
>>> diff --git a/meta/recipes-core/eglibc/eglibc-package.inc b/meta/recipes-core/eglibc/eglibc-package.inc
>>> index a590cce..1a23805 100644
>>> --- a/meta/recipes-core/eglibc/eglibc-package.inc
>>> +++ b/meta/recipes-core/eglibc/eglibc-package.inc
>>> @@ -76,6 +76,10 @@ do_install_append () {
>>>        rm -f ${D}${sysconfdir}/localtime
>>>        rm -rf ${D}${localstatedir}
>>> 
>>> +       # remove empty eglibc dir
>>> +       if [ -d ${D}${libdir}/eglibc ]; then
>>> +               rmdir ${D}${libdir}/eglibc
>>> +       fi
>>>        oe_multilib_header bits/syscall.h
>>> 
>>>        if [ -f ${D}${bindir}/mtrace ]; then
>> 
>> This breaks in the case the directory exists and is not empty - which
>> is the case when you build with eglibc-2.17. In that case there is a
>> pt_chown binary. pt_chown is deprecated since devpts was invented, and
>> now removed in 2.18.
> 
> Can we use just
> rmdir --ignore-fail-on-non-empty ${D}${libdir}/eglibc
> ?

yes however the reason to not use it in first place was to catch these kind of issues.

> 
> -- 
> Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com