[OE-core] [PATCH] grep-2.5.1a: fix grep for LSB compliance

[Saul Wold]

On 08/26/2013 09:32 PM, Li Zhijian wrote:
> ...skip... at 2013-8-27 9:00, Saul Wold wrote:
>>> diff --git a/meta/recipes-extended/grep/grep_2.5.1a.bb
>>> b/meta/recipes-extended/grep/grep_2.5.1a.bb index
>>> 088959c..d964d84 100644 ---
>>> a/meta/recipes-extended/grep/grep_2.5.1a.bb +++
>>> b/meta/recipes-extended/grep/grep_2.5.1a.bb @@ -5,7 +5,7 @@
>>> SECTION = "console/utils" LICENSE = "GPLv2" LIC_FILES_CHKSUM =
>>> "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
>>>
>>> -PR = "r2" +PR = "r3"
>>>
>>> SRC_URI = "${GNU_MIRROR}/grep/grep-${PV}.tar.bz2 \
>>> file://uclibc-fix.patch \ @@ -13,8 +13,25 @@ SRC_URI =
>>> "${GNU_MIRROR}/grep/grep-${PV}.tar.bz2 \ file://gettext.patch \
>>> file://fix64-int-to-pointer.patch \ file://Makevars \ -
>>> file://grep-CVE-2012-5667.patch \
>>
>> Why are you removing this patch?
>>
>> Will an update to 2.5.3 accomplish the same thing as these
>> patches?
>>
>> Also all of your patches above are missing Upstream-Status and
>> Signed-off-by:
>>
>> See the Patch Guildlines on OE-Core:
>> http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
>>
>> Thanks
>>
>> Sau!
>>
>>
> ...skip...
>>> + file://grep-CVE-2012-5667.patch \
> ...skip...
>
> Thank a lots for your comments.
>
> This patch is not removed ,it is here ↑
>
> I don't know what's fixed bettwen 2.5.1a an 2.5.3, but grep-2.5.3
> LICENSE is GPLv3+ differed from 2.5.1a(GPLv2)
>
> The Guildlines is very helpful for me. But those patch is come from
> grep-2.5.1-55.el5.src.rpm and I have not research this patch's
> Upstream-Status and Signed-off-by So I am sorry about that
>

Please review the recipes and licenesing, since it seems the we might
have multiple versions and the license fields are incorrect for both.

If there are both v2 and v3 versions, we need to ensure which is correct.

Thanks
	Sau!

> Thanks Li,
>
>
>