[OE-core] [WIP][PATCH 17/20] librsvg: Fix dependencies for PACKAGECONFIG gdkpixbuf

Martin Jansa martin.jansa at gmail.com
Thu Aug 29 18:30:21 UTC 2013


On Thu, Aug 29, 2013 at 10:49:03AM -0700, Saul Wold wrote:
> On 08/29/2013 09:03 AM, Martin Jansa wrote:
> > * without gtk+ or gdk-pixbuf available it gets disabled even with --enable-pixbuf-loader
> >
> > Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>
> > ---
> >   meta/recipes-gnome/librsvg/librsvg_2.32.1.bb | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-gnome/librsvg/librsvg_2.32.1.bb b/meta/recipes-gnome/librsvg/librsvg_2.32.1.bb
> > index 4818422..30846bf 100644
> > --- a/meta/recipes-gnome/librsvg/librsvg_2.32.1.bb
> > +++ b/meta/recipes-gnome/librsvg/librsvg_2.32.1.bb
> > @@ -29,7 +29,7 @@ PACKAGECONFIG ??= "croco gdkpixbuf"
> >   # Support embedded CSS stylesheets (recommended upstream)
> >   PACKAGECONFIG[croco] = "--with-croco,--without-croco,libcroco"
> >   # gdk-pixbuf loader
> > -PACKAGECONFIG[gdkpixbuf] = "--enable-pixbuf-loader,--disable-pixbuf-loader"
> > +PACKAGECONFIG[gdkpixbuf] = "--enable-pixbuf-loader,--disable-pixbuf-loader,gtk+ gdk-pixbuf"
> 
> I think this needs to be a target only PACKAGECONFIG, as it will try to 
> depend on gtk+-native when building the librsvg-native.

Yes I've noticed it couple minutes after sending this patchset and it's
already fixed in branch (just not squashed yet - waiting for next
build).

Thanks for review

> 
> Sau!
> 
> >   # GTK+ 2 theme engine
> >   PACKAGECONFIG[gtk] = "--enable-gtk-theme,--disable-gtk-theme,gtk+"
> >
> >

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20130829/e99f9363/attachment-0002.sig>


More information about the Openembedded-core mailing list