[OE-core] BB_NO_NETWORK broken for git

[Richard Purdie]

On Thu, 2013-12-05 at 08:24 -0700, Gary Thomas wrote:
> On 2013-12-05 08:09, Richard Purdie wrote:
> > On Thu, 2013-12-05 at 07:09 -0700, Gary Thomas wrote:
> >> On 2013-12-05 06:50, Richard Purdie wrote:
> >>> On Thu, 2013-12-05 at 05:18 -0700, Gary Thomas wrote:
> >>>> I try to use a local source mirror, fully populated with packages, so I
> >>>> can deliver a complete (no network required) bundle to my customers.  This
> >>>> has recently been broken.
> >>>>
> >>>> I can no longer use BB_NO_NETWORK=1 for git recipes, since this revision:
> >>>> commit 2354250a95eab484459f41f8715ae112295c2174
> >>>> Author: Richard Purdie <richard.purdie at linuxfoundation.org>
> >>>> Date:   Mon Nov 18 17:17:16 2013 +0000
> >>>
> >>> Its actually the metadata that has the issue. The commit specified is
> >>> not on the master branch, its on the cross_prelink branch so the fetcher
> >>> is justifiably getting upset.
> >>>
> >>> When the network is present it does a complete reset to upstream and
> >>> then assumes the revision is present though which is something we might
> >>> want to fix too.
> >>>
> >>> For now we can at least correct the metadata to point at the right
> >>> branch. I've sent out a patch accordingly.
> >>
> >> Does this work for other git based repositories?  My example was for
> >> prelink, but it seems to fail for me for any SRC_URI that uses git.
> >> For example, matchbox-keyboard also fails under the same test scenario.
> >
> > Its the same problem. The commit referenced is not on master but on a
> > different branch. The URL needs fixing to point at the right branch.
> 
> So I just [luckily] picked two recipes that have incorrect SRC_URI??
> How many others will there be?  I'd wager most all since very few of
> them actually mention a branch, just a revision.

Most git trees use the master branch which is the default so most urls
are fine. 

I just added something to the fetcher to detect this (which I will
merge), then ran a world fetchall against OE-Core master.

We appear to have issues with lttng-{modules,ust,tools} and mx so its
far from "all" git recipes.

Cheers,

Richard