[OE-core] [PATCH 3/4] libsdl: Use 'virtual/libx11' instead of hardcoding nativesdk-libx11

Otavio Salvador otavio at ossystems.com.br
Sun Feb 17 13:55:58 UTC 2013


On Sun, Feb 17, 2013 at 10:46 AM, Richard Purdie
<richard.purdie at linuxfoundation.org> wrote:
> On Sun, 2013-02-17 at 10:42 -0300, Otavio Salvador wrote:
>> On Sun, Feb 17, 2013 at 4:52 AM, Richard Purdie
>> <richard.purdie at linuxfoundation.org> wrote:
>> > On Sat, 2013-02-16 at 19:20 -0200, Otavio Salvador wrote:
>> >> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
>> >> ---
>> >>  meta/recipes-graphics/libsdl/libsdl_1.2.15.bb | 2 +-
>> >>  1 file changed, 1 insertion(+), 1 deletion(-)
>> >>
>> >> diff --git a/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb b/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb
>> >> index e25c597..3dbe97a 100644
>> >> --- a/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb
>> >> +++ b/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb
>> >> @@ -16,7 +16,7 @@ DEPENDS = "${@base_contains('DISTRO_FEATURES', 'directfb', 'directfb', '', d)} \
>> >>             ${@base_contains('DISTRO_FEATURES', 'opengl', 'virtual/libgl', '', d)} \
>> >>             ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 libxext libxrandr libxrender', '', d)} \
>> >>             tslib"
>> >> -DEPENDS_class-nativesdk = "${@base_contains('DISTRO_FEATURES', 'x11', 'nativesdk-libx11 nativesdk-libxrandr nativesdk-libxrender nativesdk-libxext', '', d)}"
>> >> +DEPENDS_class-nativesdk = "${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 nativesdk-libxrandr nativesdk-libxrender nativesdk-libxext', '', d)}"
>> >
>> > Don't you mean virtual/nativesdk-libx11 ?
>>
>> Other places are using virtual/libx11 so I sticked to it.
>
> Other places in nativesdk overrides?

Yes; I can check it again.

>>  For me it
>> has worked but I did not change if it'd choose the right package when
>> building with 'x11' (as my project now builds without it).
>
> That doesn't make it correct.

I will check and post v2.

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br




More information about the Openembedded-core mailing list