[OE-core] [PATCH 5/7] mkdebugfs.sh: several fixes

Darren Hart dvhart at linux.intel.com
Tue Feb 26 21:50:38 UTC 2013



On 02/26/2013 09:43 AM, Trevor Woerner wrote:
> On Tue, Feb 26, 2013 at 4:24 AM, Robert Yang <liezhi.yang at windriver.com> wrote:
>> Fix mkdebugfs.sh:
>>
>>          *)
>>              echo "Unknown file $FILE" 1>&2
>>              ;;
>>          esac
> 
> I know this doesn't come from your work, but since you're making
> changes, I think it would make for a better error message if the above
> said something along the lines of:
> 
>     echo "Unknown/unhandled file type '$(stat -c "%F" $FILE)' file:$FILE"
> 

That's fine. Also, there is no need to send my script first and then
patch it. It was a 5 minute hack, so just modify and include as a single
patch.


-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel




More information about the Openembedded-core mailing list