[OE-core] [PATCH] package.bbclass: Skip testing "packages" a second time.

Robert P. J. Day rpjday at crashcourse.ca
Thu Jan 3 16:01:07 UTC 2013


Since the "packages" variable is already tested a few lines above in
the same routine:

    if len(packages) < 1:
        bb.debug(1, "No packages to build, skipping do_package")
        return

there is no point testing it again, and the error message doesn't even
refer to "packages", anyway.

Signed-off-by: Robert P. J. Day <rpjday at crashcourse.ca>

---

diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index 1ac6551..e609260 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -1885,7 +1885,7 @@ python do_package () {
     dvar = d.getVar('PKGD', True)
     pn = d.getVar('PN', True)

-    if not workdir or not outdir or not dest or not dvar or not pn or not packages:
+    if not workdir or not outdir or not dest or not dvar or not pn:
         bb.error("WORKDIR, DEPLOY_DIR, D, PN and PKGD all must be defined, unable to package")
         return


-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================




More information about the Openembedded-core mailing list