[OE-core] [PATCH 1/3] Wayland userspace library initial 1.0.3

Burton, Ross ross.burton at intel.com
Tue Jan 8 09:52:19 UTC 2013


On 7 January 2013 16:06, Alex DAMIAN <alexandru.damian at intel.com> wrote:
> +do_install_append_class-native() {
> +  sed -i -e '4,10s,prefix=.*$,prefix=${D}/${prefix},;4,10s,exec_prefix=,exec_prefix=${D}/${exec_prefix},' \
> +    ${D}/${datadir}/aclocal/wayland-scanner.m4
> +}

My previous comments still stand:

The use of addresses seems fragile, would it be safer to inject the
paths pre-configure when @prefix@ is easily replaceable?  As is to
demonstrate this, you missed a @datarootdir@ replacement.  Probably
best to do a replacement pre-configure on the @foo@ symbols.

Also using STAGING_BINDIR_NATIVE and STAGING_DATADIR_NATIVE would be clearer.

Ross




More information about the Openembedded-core mailing list