[OE-core] [PATCH 4/5] lib/oe/path.py: Use shutil.rmtree if the path we wish to remove is a directory.

[Martin Ertsaas]

On 01/10/13 15:15, Chris Larson wrote:
>
> On Thu, Jan 10, 2013 at 1:50 AM, Martin Ertsaas <martiert at gmail.com
> <mailto:martiert at gmail.com>> wrote:
>
>     On mac, os.unlink can not be done to remove directories, and so we
>     have to
>     explicitly use shutil.rmtree instead to support mac.
>
>
> As pointed out for the bitbake patch, the functions can already handle
> this case if you pass recurse=True, and mac isn't at all special in
> this context.
> -- 
> Christopher Larson
True. In this case though, I feel the patch is still valid though, and
that I should instead change the commit message. What I want from this
patch, as I see it again now, is to not duplicate the same code in both
bitbake and oe-core, when the oe-core function 'remove' can just be
calling bb.utils.remove. So personally I still want this patch, I just
wish to change the commit message to something sane. Agreed?

- Martin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20130111/b5adceef/attachment-0002.html>