[OE-core] [PATCH 00/21][RFC v3] systemd Integration

[Radu Moisan]

On 01/12/2013 01:23 AM, Saul Wold wrote:
> On 01/08/2013 04:24 AM, Radu Moisan wrote:
>> As Ross suggested I've done the following changes to the previous set:
>> * added two patches (the first two) that address multiple init 
>> systems support,\
>> as in shifting from default hardcoded sysvinit to something more 
>> generic while
>> the default values still remains on sysvinit
>> * moved automatic setting of PREFERRED_PROVIDER_udev into 
>> default_providers.inc
>> * removed ahavi-systemd since all it provided was service files; now 
>> service files
>> are pulled in by avahi-daemon
>> * also rebased on master
>>
>> The following changes since commit 
>> 7e1f8faad0c4b6f490c26f87acc698dd6e002b15:
>>
>>    perl: Remove bashism from perl-tests.inc (2013-01-07 22:37:37 +0000)
>>
>> are available in the git repository at:
>>
>>    git://git.yoctoproject.org/poky-contrib rmoisan/systemd
>> http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=rmoisan/systemd
>>
>> Enrico Scholz (1):
>>    systemd: move disable operation into prerm() script
>>
>> Holger Hans Peter Freyther (2):
>>    systemd: Make the main systemd files proper CONFFILES
>>    systemd: Introduce a create-volatile to create tmp directories
> White space 4 spaces vs tab

Fixed.

>
>>
>> Khem Raj (1):
>>    systemd: Fix build when base_libdir is not /lib
>>
>> Martin Donnelly (2):
>>    cgroups: Add INSANE_SKIP to avoid warning about .so file
>>    systemd: Remove sysvinit mount related services if systemd is enabled
>>
>> Martin Jansa (2):
>>    systemd: fix FILESPATH to find systemctl
>>    systemd: add PACKAGES_DYNAMIC
>>
>> Radu Moisan (13):
>>    default-distrovars: Add DISTRO_FEATURES_INITMAN to DISTRO_FEATURES
>>    default-providers: Automatically set PREFERRED_PROVIDER_udev
>>    systemd: initial integration
> I believe this was mentioned before, but can you avoid making white 
> space changes, you seem to have changed tabs (which we use tabs for 
> shell based functions and 4 spaces for python based functions)
>
> Specifically, I saw some changes in wpa-supplicant-1.0.inc, busybox, 
> dropbear, initscripts
>
Reviewed those files and cleaned them up to comply.

> For the systemd-serialgetty, can we not carry around a LICENSE file, 
> and instead point to the meta/files/common-licenses for a checksum?
>

Done.

> Also a load of the patches do not contains Signed-off-by or 
> Upstream-Status tags.
>

Updated Signed-off-by
yet to check and update Upstream-Status.

>
>>    systemd: Add systemd_base.bbclass
>>    systemd: Add systemd option to PREFERRED_PROVIDER_udev
>>    systemd: set default.target to multi-user.target
>>    systemd: update FILESPATH with *-native directory
>>    systemd: disable sysfs.service
> White space changes, makes it much harder to review, please fix

corrected white spaces.
disabled hostname.sh, mountall.sh, mountnfs.sh and sysfs.sh when running 
with systemd
changed patch header & description

>
>
>>    systemd: Add systemd-compat-units
>>    systemd: Add avahi to packagegroup-core-boot
>>    xserver-nodm-init: Enable systemd support
>>    util-linux: Enable systemd support
> What's the actual change here?  Whitespace?

dropped.
white space issues fixed in initial commit.

>>    systemd: Disable xz when building with GPLv3 incompatibility flag
> This should go away, I have verified that the license field in xz is 
> wrong and should not contain GPLv3 since it's a build macro, not a 
> runtime, and the LICENSE field pertains to packaged and installed 
> items and their licenses.
>
dropped.

Radu