[OE-core] [PATCH 1/2] xinetd: enable tcp-wrappers support by DISTRO_FEATURE

[Saul Wold]

On 01/18/2013 08:37 PM, Rongqing Li wrote:
>
>
> On 01/18/2013 04:26 PM, Martin Jansa wrote:
>> On Fri, Jan 18, 2013 at 10:56:22AM +0800, rongqing.li at windriver.com
>> wrote:
>>> From: "Roy.Li" <rongqing.li at windriver.com>
>>>
>>> Signed-off-by: Roy.Li <rongqing.li at windriver.com>
>>> ---
>>>   meta/recipes-extended/xinetd/xinetd_2.3.15.bb |    5 ++++-
>>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-extended/xinetd/xinetd_2.3.15.bb
>>> b/meta/recipes-extended/xinetd/xinetd_2.3.15.bb
>>> index 3bde512..9278cc2 100644
>>> --- a/meta/recipes-extended/xinetd/xinetd_2.3.15.bb
>>> +++ b/meta/recipes-extended/xinetd/xinetd_2.3.15.bb
>>> @@ -7,7 +7,7 @@ LICENSE = "BSD"
>>>   LIC_FILES_CHKSUM =
>>> "file://COPYRIGHT;md5=8ad8615198542444f84d28a6cf226dd8"
>>>
>>>   DEPENDS = ""
>>> -PR = "r1"
>>> +PR = "r2"
>>>
>>>   SRC_URI = "http://www.xinetd.org/xinetd-${PV}.tar.gz \
>>>         file://xinetd.init \
>>> @@ -28,6 +28,9 @@ INITSCRIPT_PARAMS = "defaults"
>>>
>>>   EXTRA_OECONF="--disable-nls"
>>>
>>> +DEPENDS += "${@base_contains('DISTRO_FEATURES', 'tcp-wrappers',
>>> 'tcp-wrappers', '', d)}"
>>> +EXTRA_OECONF += "${@base_contains('DISTRO_FEATURES', 'tcp-wrappers',
>>> '--with-libwrap', '', d)}"
>>> +
>>
>> Why not use PACKAGECONFIG here?
>>
>
> Enabling tcp-wrapper is not a random thing for some customer,
> it is a must. So I think feature is more suitable
>
Martin's point is you can use the PACKAGECONFIG syntax here instead of 2 
base_contains.

for example:
PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'tcp_wrappers', 
'tcp_wrappers', '', d)}"
PACKAGECONFIG[tcp_wrappers] = "--with-libwrap,--without-libwrap, 
tcp_wrappers"

See docs for more information.

Sau!



> -Roy
>
>> Cheers,
>>
>>>   do_configure() {
>>>       # Looks like configure.in is broken, so we are skipping
>>>       # rebuilding configure and are just using the shipped one
>>> --
>>> 1.7.10.4
>>>
>>>
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core at lists.openembedded.org
>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
>