[OE-core] [PATCH 04/17] insane.bbclass: Fix incorrect getVar call
Richard Purdie
richard.purdie at linuxfoundation.org
Wed Jan 30 14:00:57 UTC 2013
On a trace I was a bit puzzled why getVar was making 180 calls to len(d).
This is an expensive operation that should be very rarely called and
certainly not by getVar. In perl's do_package it was resulting in
~1.5 million function calls from those 180 cases.
Ultimately this typo was why. Lets fix it and save the CPU cyles.
Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
meta/classes/insane.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index c5c84b8..015abd5 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -404,7 +404,7 @@ def package_qa_check_arch(path,name,d, elf, messages):
target_os = d.getVar('TARGET_OS', True)
target_arch = d.getVar('TARGET_ARCH', True)
- provides = d.getVar('PROVIDES', d, True)
+ provides = d.getVar('PROVIDES', True)
bpn = d.getVar('BPN', True)
# FIXME: Cross package confuse this check, so just skip them
--
1.7.10.4
More information about the Openembedded-core
mailing list