[OE-core] [PATCH] gtk-icon-cache: Fix rdepends construction

[Chris Larson]

On Thu, Jan 31, 2013 at 12:50 PM, Chris Larson <clarson at kergoth.com> wrote:

> On Thu, Jan 31, 2013 at 12:11 PM, Saul Wold <sgw at linux.intel.com> wrote:
>
>> -        rdepends = d.getVar('RDEPENDS_%s' % pkg, True)
>> -        rdepends = rdepends + ' ' + d.getVar('MLPREFIX') +
>> "hicolor-icon-theme"
>> -        d.setVar('RDEPENDS_%s' % pkg, rdepends)
>> +        rdepends = ' ' + d.getVar('MLPREFIX') + "hicolor-icon-theme"
>> +        d.appendVar('RDEPENDS_%s' % pkg, rdepends)
>>
>
> The new version isn't using a getVar of the old rdepends at all, so it's
> just replacing it every time. Is that really what you intended here?
> Wouldn't a getVar() or '' be a better approach? Further, the '' +
> d.getVar('MLPREFIX') is pointless if you aren't including the original
> value, as it adds a separator to the beginning when there's nothing to
> separate.


Erm, ignore this, I'm apparently blind as a bat if I can't see 'appendVar'
:)
-- 
Christopher Larson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20130131/f532cb3d/attachment-0002.html>