[OE-core] [PATCH] directfb: don't patch pkg-config files

[Nicolas Dechesne]

On Fri, Jul 19, 2013 at 10:39 AM, André Draszik <andre.draszik at linaro.org>wrote:

> We are currently getting build failures of projects that rely on
> being able to access DirectFB's internal include directories, as
> returned via pkg-config, since the include paths returned by
> pkg-config are incomplete.
>
> The reason for that is the patch that is being removed with this
> change. It modified the cflags returned by pkg-config in an
> incorrect way, causing us to miss important include paths:
>
> For reference, pkg-config output with incorrect patch applied:
>   ad at bril0118 #513 ~> pkg-config --cflags directfb-internal
> -D_GNU_SOURCE -D_REENTRANT
> -I<builddir>/tmp/sysroots/<machine>/usr/include/directfb
> -I<builddir>/tmp/sysroots/<machine>/usr/include
>
> Now, with the incorrect patch removed, the output is as expected:
>   ad at bril0118 #514 ~> pkg-config --cflags directfb-internal
> -D_GNU_SOURCE -D_REENTRANT
> -I<builddir>/tmp/sysroots/<machine>/usr/include/directfb-internal
> -I<builddir>/tmp/sysroots/<machine>/usr/include/directfb
>
> Overall, the removed patch is not needed - pkg-config does the right
> thing these days and we can simply use the correctly working upstream
> versions of all DirectFB .pc files.
>
> Signed-off-by: André Draszik <andre.draszik at linaro.org>
>

i reviewed and tested this patch against a QT4e image build. it looks good
to me, and that offending patch being removed seems to come from quite
ancient stuff.

Tested-by: Nicolas Dechesne <nicolas.dechesne at linaro.org>

any chance this can get into 'dylan', too?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20130719/3ba585e9/attachment-0002.html>