[OE-core] [PATCH] cpan.bbclass: Fail unless Makefile.PL generates Makefile
Olof Johansson
olof.johansson at axis.com
Mon Jul 22 09:35:47 UTC 2013
Makefile.PLs can exit with success without generating a Makefile,
e.g. in cases of missing configure time dependencies. This is
considered a best practice by cpantesters.org. See:
* http://wiki.cpantesters.org/wiki/CPANAuthorNotes
* http://www.nntp.perl.org/group/perl.qa/2008/08/msg11236.html
Signed-off-by: Olof Johansson <olof.johansson at axis.com>
---
meta/classes/cpan.bbclass | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/meta/classes/cpan.bbclass b/meta/classes/cpan.bbclass
index bef9e82..7088039 100644
--- a/meta/classes/cpan.bbclass
+++ b/meta/classes/cpan.bbclass
@@ -18,6 +18,15 @@ export PERLHOSTLIB = "${STAGING_LIBDIR_NATIVE}/perl-native/perl/${@get_perl_vers
cpan_do_configure () {
export PERL5LIB="${PERL_ARCHLIB}"
yes '' | perl ${EXTRA_PERLFLAGS} Makefile.PL ${EXTRA_CPANFLAGS}
+
+ # Makefile.PLs can exit with success without generating a
+ # Makefile, e.g. in cases of missing configure time
+ # dependencies. This is considered a best practice by
+ # cpantesters.org. See:
+ # * http://wiki.cpantesters.org/wiki/CPANAuthorNotes
+ # * http://www.nntp.perl.org/group/perl.qa/2008/08/msg11236.html
+ [ -e Makefile ] || bbfatal "No Makefile was generated by Makefile.PL"
+
if [ "${BUILD_SYS}" != "${HOST_SYS}" ]; then
. ${STAGING_LIBDIR}${PERL_OWN_DIR}/perl/config.sh
# Use find since there can be a Makefile generated for each Makefile.PL
--
1.7.10.4
More information about the Openembedded-core
mailing list