[OE-core] [PATCH] avahi: Remove unnecessary runtime dependency on sysvinit-pidof

Saul Wold sgw at linux.intel.com
Thu Jul 25 16:43:43 UTC 2013


On 07/25/2013 03:02 AM, Shakeel, Muhammad wrote:
> From: Muhammad Shakeel <muhammad_shakeel at mentor.com>
>
> 'pidof' is alternatively coming from busybox so no need for avahi to explicitly
> rdepend on sysvinit-pidof. This unnecessarily includes sysvinit in systemd only
> build.
>
> Signed-off-by: Muhammad Shakeel <muhammad_shakeel at mentor.com>
> ---
>   meta/recipes-connectivity/avahi/avahi.inc |    2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/meta/recipes-connectivity/avahi/avahi.inc b/meta/recipes-connectivity/avahi/avahi.inc
> index c302f87..7bb5381 100644
> --- a/meta/recipes-connectivity/avahi/avahi.inc
> +++ b/meta/recipes-connectivity/avahi/avahi.inc
> @@ -96,8 +96,6 @@ FILES_libavahi-glib = "${libdir}/libavahi-glib.so.*"
>   FILES_libavahi-gobject = "${libdir}/libavahi-gobject.so.*"
>   FILES_avahi-utils = "${bindir}/avahi-*"
>
> -RDEPENDS_avahi-daemon = "sysvinit-pidof"
> -
I am sure there was a reason that the sysvinit version of pidof was 
required over the busybox, did you test that the busybox version works 
correctly in both systemd and sysvinit usages?

It maybe that the busybox version now work correctly.

Also as Paul pointed out, this is an RDEPENDS on a single package not 
all the sysvinit packages.

Sau!

>   # uclibc has no nss
>   RRECOMMENDS_avahi-daemon_append_libc-glibc = "libnss-mdns"
>   RRECOMMENDS_${PN}_append_libc-glibc = "libnss-mdns"
>



More information about the Openembedded-core mailing list