[OE-core] [PATCH 1/2] [V2] systemd: Remove init.d dir if systemd unit file is present and sysvinit not a distro feature

Phil Blundell pb at pbcl.net
Mon Jul 29 14:36:58 UTC 2013


On Mon, 2013-07-29 at 15:34 +0100, Burton, Ross wrote:
> On 29 July 2013 09:09, Shakeel, Muhammad <muhammad_shakeel at mentor.com> wrote:
> > +        # If systemd_unitdir contains anything, delete sysv_initddir
> > +        if (os.path.exists(systemd_unitdir) and os.listdir(systemd_unitdir)):
> > +            shutil.rmtree(sysv_initddir)
> 
> Not sure we need the listdir(), why should the function only delete
> the directory if it has contents?  If it doesn't have contents you'll
> be packaging an empty directory.

The directory he's deleting is different to the one that he's listing.

p.





More information about the Openembedded-core mailing list