[OE-core] [PATCH] base.bbclass: Add support to EXTRA_DISTRO_FEATURES
Otavio Salvador
otavio at ossystems.com.br
Tue Jul 30 12:24:43 UTC 2013
On Tue, Jul 30, 2013 at 9:14 AM, Phil Blundell <pb at pbcl.net> wrote:
> On Tue, 2013-07-30 at 09:00 -0300, Otavio Salvador wrote:
>> To make this, we cannot reuse Poky distro for example as it
>> /unconditionally/ appends to DISTRO_FEATURES. Besides it is easier for
>> test to be able to override it using local.conf. For products I agree
>> we'll end adding a distro to make it reprodicable but for development
>> stage this trick makes life much easier.
>
> Surely for one-off tests you can just write out the whole intended value
> of DISTRO_FEATURES in your local.conf. It doesn't seem as though this
> variable is unwieldy enough that it really needs mechanical handling.
>
> As for poky appending to DISTRO_FEATURES rather than just setting it,
> that sounds like it's arguably a bug in poky and you should perhaps take
> it up with those guys. Of course, they might take the view that poky
> itself is meant to be determining what DISTRO_FEATURES it wants and they
> don't want to support or encourage random frobbing of flags by third
> parties, and I think that'd be an understandable position.
>
>>We call it and /finalize/ the database so it has _append/_prepend
>>resolved before mangling the list.
>
> That seems a bit unwholesome in itself. Are you sure there are no
> potential bad consequences from calling finalize() there?
No; I am not sure. What I know is it has been being used by meta-metro
and O.S. Systems distribution without issues for a while and it solves
the problem I have.
Adding /full/ distro features list is ugly and easy to get wrong. This
seems much better for user IMO.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
More information about the Openembedded-core
mailing list