[OE-core] [oe-commits] Andy Voltz : tune-cortexa.inc: create a common include for cortex-a armv7a tuning

[Khem Raj]

On Jun 12, 2013, at 9:13 AM, Andy Voltz <andy.voltz at timesys.com> wrote:

> Hi Khem,
> 
>> On Tue, Jun 11, 2013 at 6:45 AM, Andy Voltz <andy.voltz at timesys.com> wrote:
>>> I understand that. I sent an updated patch which reverts to mtune, but I'm getting
>> 
>> mtune/march is small issue with this patch. I would recommend to send
>> a revert of the patches
>> since all arm architectures are broken as of now in OE-Core
> 
> I see the issue now. It seems that overriding the tunes with a variable
> reference does not work for all the tunings. With the tune test script, I'm
> seeing that these tunes are broken:
> log.fake-cortexa9.cortexa9*
> log.fake-cortexa8.cortexa8*
> 
> I see that variables can be assigned with a reference based on stuff like 
> FILES_${QT_BASE_NAME}-fonts = …
> 
> (From recipes-qt/qt4/qt4-embedded.inc)
> 
> I'm not sure why it works there and not in the tunings, or how to fix.
> 


its a different thing. Its constructing a variable name and not override. You were trying to create a override on the fly
that won't work.

> For now I have a revert patch which removes tune-cortexa.inc and restores the
> previous contents of the a7,a8,a9,15 tuning files. 
> 
> It also adds the tune-cortexa5.inc file I had sent on the list originally
> which led to this code-reduction experiment. That thread is here for reference:
> 
> http://lists.openembedded.org/pipermail/openembedded-core/2013-June/079452.html
> 
> Thanks for pointing out this issue. Patch is on the way.
> 

np


> Regards
> -- 
> Andy Voltz
> Timesys Corporation