[OE-core] [PATCH] libx11: enable Xcms by default

[Jonathan Liu]

On 20 June 2013 16:34, Phil Blundell <pb at pbcl.net> wrote:
> On Thu, 2013-06-20 at 11:54 +1000, Jonathan Liu wrote:
>> The following do not work if Xcms is not enabled in libx11:
>> - starting xterm and doing ls --color / fails to color code the
>>   directories:
>>   xterm: Cannot allocate color "rgb:5c/5c/ff"
>> - xsetroot -solid rgb:5c/5c/ff fails with the following error:
>>   xsetroot:  unknown color "rgb:5c/5c/ff"
>> - xsetroot -solid rgbi:1.0/1.0/1.0 fails with the following error:
>>   xsetroot:  unknown color "rgbi:1.0/1.0/1.0"
>>
>> More specifically, applications that pass Xcms color names to
>> XParseColor do not work properly.
>
> The comment that you are deleting suggests that this behaviour is by
> design:
>
>> -# Let people with incredibly archaic requirements enable Xcms, but disable it by
>> -# default.
>
> Since there's already a PACKAGECONFIG option for this, can't you just
> enable that in your distro configuration rather than changing the
> default?  I don't think it's ever been the expectation that the default
> settings will represent "maximum functionality".
>
> p.
>
>

I already do enable it in my distro configuration. The motivation for
having this enabled by default is that discovering that applications
don't work as expected and then trying to track down what is causing
it can take up quite a bit of time. This time would have been better
spent on actual application development.

If it is not needed, the PACKAGECONFIG can be overridden or
libx11-diet used instead.

Regards,
Jonathan