[OE-core] [PATCH] eglibc: Handle QA warnings in nativesdk (denzil)

Phil Blundell philb at gnu.org
Fri Mar 8 23:25:33 UTC 2013


On Fri, 2013-03-08 at 14:07 -0800, Rich Dubielzig wrote:
> -FILES_${PN}-utils = "${bindir}/* ${sbindir}/*"
> +FILES_${PN}-utils = "${bindir}/* ${sbindir}/* ${base_sbindir}/ldconfig ${sysconfdir}/ld.so.conf"

Is that really correct?  There seem to be several slightly dubious
things about this patch:

1. In the version of oe-core I'm looking at, both ldconfig and
ld.so.conf go into ${PN} if USE_LDCONFIG=1, which is the default.
(Arguably this ought really to be a DISTRO_FEATURE nowadays.)  So,
adding them unconditionally to PN-utils seems like it is confusing at
best.

2. ld.so.conf isn't a utility and it isn't entirely obvious that it
belongs in PN-utils at all.

3. Your commit message didn't mention the change to ldconfig, and also
didn't give any details of what exactly the QA warnings were that it was
fixing.

thanks

p.






More information about the Openembedded-core mailing list