[OE-core] [PATCH] ia32-base.inc: remove inapropriate grub dependency

Darren Hart dvhart at linux.intel.com
Wed May 1 20:56:36 UTC 2013



On 05/01/2013 01:51 PM, Tomas Frydrych wrote:
> On 01/05/13 21:25, Darren Hart wrote:
>>
>>
>> On 04/27/2013 01:52 AM, tf+lists.yocto at r-finger.com wrote:
>>> From: Tomas Frydrych <tomas at sleepfive.com>
>>>
>>> There is no good reason for ia32 machines to have hard dependency on grub,
>>> as there are other bootloaders available for ia32 platforms.
>>>
>>> Signed-off-by: Tomas Frydrych <tomas at sleepfive.com>
>>> ---
>>>  meta/conf/machine/include/ia32-base.inc |    1 -
>>>  1 file changed, 1 deletion(-)
>>>
>>> diff --git a/meta/conf/machine/include/ia32-base.inc b/meta/conf/machine/include/ia32-base.inc
>>> index 921c740..cb542a5 100644
>>> --- a/meta/conf/machine/include/ia32-base.inc
>>> +++ b/meta/conf/machine/include/ia32-base.inc
>>> @@ -9,7 +9,6 @@ MACHINE_FEATURES += "screen keyboard pci usbhost ext2 ext3 x86 \
>>>                       acpi serial usbgadget alsa"
>>>  
>>>  MACHINE_EXTRA_RRECOMMENDS += "kernel-modules eee-acpi-scripts"
>>> -MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "grub"
>>
>> Agreed - but do the images still build as currently written after you
>> remove it here?
> 
> I have not tested the efi path, though I think the grub-efi.bbclass
> takes care of the grub dependency. In the non-efi case the grub
> dependency is taken care of by initramfs-live-install.bb.

grub-efi is properly managed via the bootimg.bbclass and
MACHINE_FEATURES ~= efi.

Acked-by: Darren Hart <dvhart at linux.intel.com>

Thanks Tomas!

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel




More information about the Openembedded-core mailing list