[OE-core] [PATCH] grub-efi-native: fix build on modern distributions without gets()

Koen Kooi koen at dominion.thruhere.net
Thu May 2 06:07:14 UTC 2013


Op 1 mei 2013, om 22:39 heeft Darren Hart <dvhart at linux.intel.com> het volgende geschreven:

>> # Native packages do not normally rebuild when the target changes.
>> # Ensure this is built once per HOST-TARGET pair.
>> @@ -28,6 +28,7 @@ SRC_URI = "ftp://ftp.gnu.org/gnu/grub/grub-${PV}.tar.gz \
>>            file://grub-2.00-disable-help2man.patch \
>>            file://check-if-liblzma-is-disabled.patch \
>> 	   file://grub-no-unused-result.patch \
>> +	   file://grub-2.00-ignore-gnulib-gets-stupidity.patch \
>            "
> 
> Please be consistent with whitespace above. I prefer TABs be used
> exclusively for indentation with spaces used for alignment. The above is
> purely alignment. However, others prefer TABs for as much of either as
> possible. Either is fine, but it must be consistent throughout the file.
> In this case, please use spaces.

I only use tabs in shell methods for oe-core, I just copied the indentation of the line above, which mixes tabs and spaces.

regards,

Koen



More information about the Openembedded-core mailing list