[OE-core] [PATCH] package.bbclass: Remove redundant chmod/chown operations

Phil Blundell pb at pbcl.net
Thu May 2 13:20:09 UTC 2013


These were introduced in 6021e309e69d823e1467648aee12a32182945569.  The
code currently reads:

                os.link(file, fpath)
                fstat = cpath.stat(file)
                os.chmod(fpath, fstat.st_mode)
                os.chown(fpath, fstat.st_uid, fstat.st_gid)

which can have no useful effect since, if "fpath" is a hard link to
"file", it will (by definition) have the same mode, uid and gid.

Signed-off-by: Phil Blundell <philb at gnu.org>
---
 meta/classes/package.bbclass |    3 ---
 1 file changed, 3 deletions(-)

diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index 4136a9f..99eda77 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -1000,9 +1000,6 @@ python populate_packages () {
             fpath = os.path.join(root,file)
             if not cpath.islink(file):
                 os.link(file, fpath)
-                fstat = cpath.stat(file)
-                os.chmod(fpath, fstat.st_mode)
-                os.chown(fpath, fstat.st_uid, fstat.st_gid)
                 continue
             ret = bb.utils.copyfile(file, fpath)
             if ret is False or ret == 0:
-- 
1.7.10.4







More information about the Openembedded-core mailing list