[OE-core] [PATCH v2 2/3] neard: Use SRCREV instead of SRCPV

Richard Purdie richard.purdie at linuxfoundation.org
Fri May 3 15:36:14 UTC 2013


On Thu, 2013-05-02 at 18:46 +0200, Martin Jansa wrote:
> On Thu, May 02, 2013 at 05:11:28PM +0100, Burton, Ross wrote:
> > On 2 May 2013 16:39, Martin Jansa <martin.jansa at gmail.com> wrote:
> > >> -PV = "0.10+git${SRCPV}"
> > >> +PV = "0.10+git${SRCREV}"
> > 
> > As the git revision is the 0.10 tag, wouldn't it be clearer to not set
> > PV as the git revision is a detail of the fetcher - this *is* 0.10.
> 
> That's fine too as long as nobody bumps SRCREV without updating PV or
> uses AUTOREV from some .inc or local.conf.

Agreed, regardless, SRCREV in PV is not correct, we shouldn't do that
and we have SRCPV for a reason.

Cheers,

Richard





More information about the Openembedded-core mailing list