[OE-core] [PATCH] eglibc: include libgcc when libpthread is enabled

[Marinescu, Bogdan A]

On Thu, May 9, 2013 at 4:20 PM, Phil Blundell <pb at pbcl.net> wrote:

> On Thu, 2013-05-09 at 15:55 +0300, Bogdan Marinescu wrote:
> >  # nptl needs libgcc but dlopens it, so our shlibs code doesn't detect
> this
> > -#RDEPENDS_${PN} += "${@['','libgcc']['nptl' in '${GLIBC_ADDONS}']}"
> > +RDEPENDS_${PN} += "${@['','libgcc']['nptl' in '${GLIBC_ADDONS}']}"
>
> Wow, it seems like this has been broken since 2008 and nobody noticed.
> That line was commented out in oe-classic e96e82cd without any real
> explanation and it's been that way ever since.
>
> That said, forcing libgcc into RDEPENDS_${PN} unconditionally like this
>

It's not exactly unconditional, it is conditioned by 'nptl' in
${GLIBC_ADDONS}. I don't know of a better way to handle this, please let me
know if you have any suggestions.
About why this line was commented out, I don't know. git blame didn't help
with this.

Thanks,
Bogdan


> is suboptimal, because programs that don't link -lpthread (or possibly
> even programs that do, if they don't use cancellation) still don't need
> libgcc.  With this change it will be impossible to avoid getting libgcc
> in an image, which will be a loss for those trying to build small images
> with single threaded programs.
>
> p.
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20130509/ba1dfed1/attachment-0001.html>