[OE-core] [PATCH] eglibc: include libgcc when libpthread is enabled

[Phil Blundell]

On Thu, 2013-05-09 at 14:19 +0100, Richard Purdie wrote:
> On Thu, 2013-05-09 at 15:55 +0300, Bogdan Marinescu wrote:
> > diff --git a/meta/recipes-core/eglibc/eglibc.inc b/meta/recipes-core/eglibc/eglibc.inc
> > index 1e04197..24fb05b 100644
> > --- a/meta/recipes-core/eglibc/eglibc.inc
> > +++ b/meta/recipes-core/eglibc/eglibc.inc
> > @@ -35,7 +35,7 @@ siteconfig_do_siteconfig_gencache_prepend = " \
> >  # nptl needs unwind support in gcc, which can't be built without glibc.
> >  DEPENDS = "virtual/${TARGET_PREFIX}gcc-initial linux-libc-headers virtual/${TARGET_PREFIX}libc-initial"
> >  # nptl needs libgcc but dlopens it, so our shlibs code doesn't detect this
> > -#RDEPENDS_${PN} += "${@['','libgcc']['nptl' in '${GLIBC_ADDONS}']}"
> > +RDEPENDS_${PN} += "${@['','libgcc']['nptl' in '${GLIBC_ADDONS}']}"
> >  PROVIDES = "virtual/libc virtual/${TARGET_PREFIX}libc-for-gcc"
> >  PROVIDES += "virtual/libintl virtual/libiconv"
> >  inherit autotools
> 
> Why/when was that line commented out originally? Also, afaik glibc
> doesn't support anything other than nptl these days so we can probably
> drop the GLIBC_ADDONS check. Khem/Phil?

It was commented out by Khem in this patch:

http://git.openembedded.org/openembedded/commit/?id=e96e82cd

for reasons that are slightly obscure but, if I had to guess, I'd say
that it had something to do with avoiding circular dependencies during
the toolchain bootstrap process.  As far as I can tell nothing else was
added to replace it and the dependency just got lost from that point
onwards.  I'm not sure whether the circularity issue still applies but
it would be worth checking that the toolchain really does still
bootstrap with the dependency reinstated.

p.