[OE-core] [PATCH 1/1] zlib: put shared libraries in base_libdir
Saul Wold
sgw at linux.intel.com
Wed May 15 08:47:56 UTC 2013
On 05/15/2013 02:35 AM, Joe Slater wrote:
> We put the shared libraries in base_libdir because at least
> one library under base_libdir, pam_cracklib.so, needs them
> and will cause a qa warning when it is built.
> ---
> meta/recipes-core/zlib/zlib_1.2.7.bb | 14 ++++++++++++++
> 1 files changed, 14 insertions(+), 0 deletions(-)
>
> diff --git a/meta/recipes-core/zlib/zlib_1.2.7.bb b/meta/recipes-core/zlib/zlib_1.2.7.bb
> index 803fec3..f5deba1 100644
> --- a/meta/recipes-core/zlib/zlib_1.2.7.bb
> +++ b/meta/recipes-core/zlib/zlib_1.2.7.bb
> @@ -6,6 +6,8 @@ SECTION = "libs"
> LICENSE = "Zlib"
> LIC_FILES_CHKSUM = "file://zlib.h;beginline=4;endline=23;md5=94d1b5a40dadd127f3351471727e66a9"
>
> +PR = "r1"
> +
> SRC_URI = "http://www.zlib.net/${BPN}-${PV}.tar.bz2 \
> file://remove.ldconfig.call.patch \
> "
> @@ -22,6 +24,18 @@ do_compile (){
>
> do_install() {
> oe_runmake DESTDIR=${D} install
> +
> + # move the shared libraries to avoid possible qa warnings
> + #
> + case ${PN} in
> + zlib-native*)
> + ;;
This should really be handled by using the classing mechanism to extend
the do_install specificaly for the "target" class. The following will
append to the do_install for the target class.
do_install_append_class-target() {}
You should also protect against the case where base_libdir == libdir
which some distro can set.
I am also still investigating if this is an appropriate move from it's
default location, I guess I need to understand further why pam_cracklib
is causing a QA Warning, can you provide the warning please.
Thanks
Sau!
> + *)
> + mkdir -p ${D}/${base_libdir}
> + mv ${D}/${libdir}/libz.so.* ${D}/${base_libdir}
> + tmp=`readlink ${D}/${libdir}/libz.so`
> + ln -sf ../../${base_libdir}/$tmp ${D}/${libdir}/libz.so
> + esac
> }
>
> BBCLASSEXTEND = "native nativesdk"
>
More information about the Openembedded-core
mailing list