[OE-core] [PATCH] connman-gnome: fixed DHCP segfault

[Ciobanu, Emilia Maria Silvia]

Hi,

When using manual ip the ipv4_config structure has all fields populated and this condition
is skipped. The only case when the data structure fields are NULL is when we have
DHCP settings and for different reasons network configurations are not done. In this
case, connman automatically renews the ipv4 configurations in less than a minute.
Ethernet manual configuration behavior remains unchanged after this fix.

Thanks,
Ema
________________________________________
From: Burton, Ross [ross.burton at intel.com]
Sent: Friday, May 17, 2013 1:52 PM
To: Ciobanu, Emilia Maria Silvia
Cc: openembedded-core at lists.openembedded.org
Subject: Re: [OE-core] [PATCH] connman-gnome: fixed DHCP segfault

On 17 May 2013 11:32, Emilia Ciobanu
<emilia.maria.silvia.ciobanu at intel.com> wrote:
> +-      if (g_str_equal(ipv4_config.method, "dhcp") == TRUE)
> ++      if (!ipv4_config.method || g_str_equal(ipv4_config.method, "dhcp") == TRUE)

Is this really the right behaviour if IPv4.Method isn't set?

Ross