[OE-core] [PATCH] runqemu: fix networking issues

[Stanacar, StefanX]

On Mon, 2013-05-20 at 13:09 +0300, Laurentiu Palcu wrote:
> After switching from ifconfig to ip, networking stopped working. This
> commit contains the following fixes:
> 
>  * set a decent broadcast address for the tap device;
>  * bring up the device;
> 
> Signed-off-by: Laurentiu Palcu <laurentiu.palcu at intel.com>
> ---
> Apparently, the autobuilder has some magic into it because all the sanity tests
> succeeded... So, I don't know why AB tests succeeded but on my machine, and several
> others, networking was broken and couldn't connect into the qemu image. If I'm
> missing something, please, do not hesitate to correct me. This patch fixes the
> issue for me though.
> 
> Thanks,
> Laurentiu
> 
>  scripts/runqemu-ifup |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/runqemu-ifup b/scripts/runqemu-ifup
> index 8948153..108d9a4 100755
> --- a/scripts/runqemu-ifup
> +++ b/scripts/runqemu-ifup
> @@ -100,7 +100,8 @@ if [ ! -x "$IPTABLES" ]; then
>  fi
>  
>  n=$[ (`echo $TAP | sed 's/tap//'` * 2) + 1 ]
> -$IFCONFIG addr add 192.168.7.$n/32 dev $TAP
> +$IFCONFIG addr add 192.168.7.$n/32 broadcast 192.168.7.255 dev $TAP
> +$IFCONFIG link set dev $TAP up
>  
>  dest=$[ (`echo $TAP | sed 's/tap//'` * 2) + 2 ]
>  $ROUTE add -host 192.168.7.$dest $TAP

This fixes the issue for me too, thought there is something very strange
here. Last week I ran master builds (with newer commits than the
ifconfig->ip change) without ever seeing this issue. But today on the
same commit that on Friday worked, I get no network. The only thing that
changed is that my machine rebooted Monday morning... (I blame the gamma
rays). Also I think ROUTE too should be changed to use ip instead of the
old route command.


Regards,
Stefan