[OE-core] [PATCH v3] base-files: add /run directory from FHS 3 draft specification

[Jonathan Liu]

On 22 May 2013 09:07, Saul Wold <sgw at linux.intel.com> wrote:

> On 05/20/2013 08:54 PM, Jonathan Liu wrote:
>
>> This adds the /run directory from the Filesystem Hierarchy Standard 3.0
>> Draft [1] and refactors the filesystem as follows:
>> - Remove creation of /var/volatile/run
>> - Remove creation of /var/volatile/lock
>> - Remove symbolic link from /var/run to /var/volatile/run
>> - Remove symbolic link from /var/lock to /var/volatile/lock
>> - Add symbolic link from /var/run to /run
>> - Add symbolic link from /var/lock -> /run/lock
>> - Add /run to /etc/fstab for sysvinit compatibility
>>
>>
> It seems that systemd or some program may still be using
> /var/volatile/run, I booted a systemd and non-systemd boot and the systemd
> had a /var/volatile/run dir.
>
> This was with your 204 system update
>
Fixed. It was creating it in systemd init.


>
> One more nit below.
>
> diff --git a/meta/recipes-core/dbus/dbus.**inc
>> b/meta/recipes-core/dbus/dbus.**inc
>> index 2be5bda..45dcf0d 100644
>> --- a/meta/recipes-core/dbus/dbus.**inc
>> +++ b/meta/recipes-core/dbus/dbus.**inc
>> @@ -12,7 +12,7 @@ DEPENDS_class-nativesdk = "nativesdk-expat
>> virtual/nativesdk-libintl"
>>   RDEPENDS_dbus = "${@base_contains('DISTRO_**FEATURES', 'ptest',
>> 'dbus-ptest-ptest', '', d)}"
>>   RDEPENDS_class-native = ""
>>
>> -INC_PR = "r6"
>> +INC_PR = "r7"
>>
>>   SRC_URI = "http://dbus.freedesktop.org/**releases/dbus/dbus-${PV}.tar.*
>> *gz <http://dbus.freedesktop.org/releases/dbus/dbus-$%7BPV%7D.tar.gz> \
>>              file://tmpdir.patch; \
>> @@ -101,9 +101,9 @@ do_install() {
>>              > ${D}${sysconfdir}/default/**volatiles/99_dbus
>>
>>
>> -       mkdir -p ${D}${localstatedir}/run/dbus
>> ${D}${localstatedir}/lib/dbus
>> +       mkdir -p ${D}${localstatedir}/lib/dbus
>>
>> -       chown messagebus:messagebus ${D}${localstatedir}/run/dbus
>> ${D}${localstatedir}/lib/dbus
>> +       chown messagebus:messagebus ${D}${localstatedir}/lib/dbus
>>
>>         chown root:messagebus ${D}${libexecdir}/dbus-daemon-**
>> launch-helper
>>         chmod 4755 ${D}${libexecdir}/dbus-daemon-**launch-helper
>> @@ -113,6 +113,9 @@ do_install() {
>>
>>         # Remove empty testexec directory as we don't build tests
>>         rm -rf ${D}${libdir}/dbus-1.0/test
>> +
>> +       # Remove /var/run/dbus as it is created on startup
>> +       rm -rf ${D}${localstatedir}/run
>>
>
> A nit in the comment.
> Your removing more than /var/run/dbus here, can you fix the comment.
>
Fixed.

>
> Sau!
>
>
I have submitted V3 patch for your review.

Regards,
Jonathan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20130522/7ae1d4a4/attachment-0002.html>