[OE-core] [PATCH v3] base-files: add /run directory from FHS 3 draft specification

Burton, Ross ross.burton at intel.com
Wed May 22 16:33:44 UTC 2013


Hi Jonathan

On 22 May 2013 02:47, Jonathan Liu <net147 at gmail.com> wrote:
> This adds the /run directory from the Filesystem Hierarchy Standard 3.0
> Draft [1] and refactors the filesystem as follows:

Good start!

> - Remove /var/run from dbus package as it is created on startup
> - Remove /var/volatile/run/resolvconf/interface from resolvconf package
>   as resolvconf package uses /etc/resolvconf/run/interface

Can these be separate patches, as they're essentially unrelated cleanups.

Please also drop all PR changes, they're not needed in oe-core.

> diff --git a/meta/files/fs-perms.txt b/meta/files/fs-perms.txt
> index becb85c..c829bec 100644
> --- a/meta/files/fs-perms.txt
> +++ b/meta/files/fs-perms.txt
> @@ -45,15 +45,14 @@ ${oldincludedir}    0755    root    root    true    0644    root    root
>
>  # Items from base-files
>  # Links
> -${localstatedir}/run   link    volatile/run
> +${localstatedir}/run   link    /run
>  ${localstatedir}/log   link    volatile/log
> -${localstatedir}/lock  link    volatile/lock
> +${localstatedir}/lock  link    /run/lock
>  ${localstatedir}/tmp   link    volatile/tmp
>
>  # Special permissions from base-files
>  # Set 1777
>  /tmp                           01777   root    root    false - - -
> -${localstatedir}/volatile/lock 01777   root    root    false - - -
>  ${localstatedir}/volatile/tmp  01777   root    root    false - - -

Nothing appears to sets mode 1777 on /run/lock.  Then again Fedora
thinks that 0755 is sufficient, although Debian uses 1777.  We should
probably keep the permissions as 1777.

diff --git a/meta/recipes-core/dbus/dbus.inc b/meta/recipes-core/dbus/dbus.inc
index 2be5bda..8055824 100644
--- a/meta/recipes-core/dbus/dbus.inc
+++ b/meta/recipes-core/dbus/dbus.inc
@@ -101,9 +101,9 @@ do_install() {
             > ${D}${sysconfdir}/default/volatiles/99_dbus


-       mkdir -p ${D}${localstatedir}/run/dbus ${D}${localstatedir}/lib/dbus
+       mkdir -p ${D}${localstatedir}/lib/dbus

Presumably dbus will create /run/dbus if required?

Ross



More information about the Openembedded-core mailing list