[OE-core] [PATCH 2/21] Add directory information to the pkgdata files

[Mark Hatle]

On 5/29/13 2:59 PM, Phil Blundell wrote:
> On Wed, 2013-05-29 at 11:30 -0500, Mark Hatle wrote:
>> It's up to the tooling that are using these files to check if the directory
>> exists, if it does not -- then using bitbake -c patch <recipe> will create it.
>> (even in the sstate-cache case.)
>
> I'm not sure whether checking that the directory exists is all that
> safe; in the shared-sstate scenario I think it's conceivable that the
> directory might exist but contain something else, or be unreadable due
> to permissions, or disappear underneath you while you're using it.
>
> And, of course, "bitbake -c patch ..." won't necessarily create the same
> ${S} that you got from pkgdata in that case, it will create it in your
> local TMPDIR.

On 5/29/13 12:36 PM, Khem Raj wrote:
 > Hi Mark
 >
 > This won't work well when package is populated from sstate is there a way for it
 > to work seamlessly across sstate it might be useful

I was looking at this again.  I thought the pkgdata was reconstructed each time 
in the current TMPDIR.  I didn't realize it was just restored from the 
sstate-cache.  (We've got other patches in layers that trigger pkgdata-like 
files to be generated as well.. and I must have gotten the two confused.)

So yes, I understand now that this won't work properly as the embedded path is 
outside of the TMPDIR.  The intention was that the path would change to match 
the current build directories TMPDIR.  And due to the magic of the sstate-cache 
checksumming, running the do_patch should result in the same sources...


So -if- others thought this was useful, I'll fix the patch to change the S/B on 
the sstate setup to the proper TMPDIR locations.  But so far I'm not hearing 
anyone who wants this -- so I'll just keep it local.

> Also, the subject line for this patch (and several others from the batch
> you just sent) is not in the right format.  Please see the guidelines on
> the wiki.

I missed that, I'll correct the commits summary lines and resubmit them.

Drop 2/21
Fixup 9, 15, & 18

Did I miss any?

--Mark

> p.
>
>