[OE-core] [PATCH 18/21] Fix problems expanding the IMAGE_INSTALL package groups

[Richard Purdie]

On Wed, 2013-05-29 at 16:28 -0500, Mark Hatle wrote:
> On 5/29/13 4:10 PM, Richard Purdie wrote:
> > On Wed, 2013-05-29 at 10:10 -0500, Mark Hatle wrote:
> >> From: Jason Wessel <jason.wessel at windriver.com>
> >>
> >> The ncurses package was generating the following error as a result
> >> of not specifing the PACKAGES_DYNAMIC correctly.  This error only
> >> appear when using the IMAGE_INSTALL list that has been expanded by
> >> the hob or from the pkgdata.
> >>
> >> ERROR: Nothing RPROVIDES 'ncurses-libtinfo'
> >>
> >> Signed-off-by: Jason Wessel <jason.wessel at windriver.com>
> >> Signed-off-by: Mark Hatle <mark.hatle at windriver.com>
> >> ---
> >>   meta/recipes-core/ncurses/ncurses.inc | 2 ++
> >>   1 file changed, 2 insertions(+)
> >>
> >> diff --git a/meta/recipes-core/ncurses/ncurses.inc b/meta/recipes-core/ncurses/ncurses.inc
> >> index 8a81381..584ad46 100644
> >> --- a/meta/recipes-core/ncurses/ncurses.inc
> >> +++ b/meta/recipes-core/ncurses/ncurses.inc
> >> @@ -29,6 +29,8 @@ BUILD_CPPFLAGS += "-D_GNU_SOURCE"
> >>   # natives don't generally look in base_libdir
> >>   base_libdir_class-native = "${libdir}"
> >>
> >> +PACKAGES_DYNAMIC = "^${PN}-.*"
> >> +
> >>   # Fall back to the host termcap / terminfo for -nativesdk and -native
> >>   # The reality is a work around for strange problems with things like
> >>   # "bitbake -c menuconfig busybox" where it cannot find the terminfo
> >
> > I'm pretty sure I talked to Jason about this and we concluded this was
> > fixed with some other change in master. Certainly this fix as it stands
> > doesn't sound right.
> 
> The original thread included libpcre, it was libpcre side was in fact fixed 
> prior to the initial patch being submitted.  ncurses however is still broken.
> 
> If I revert this commit in my tree, and add to IMAGE_INSTALL "ncurses-libtinfo", 
> I get the following failure:
> 
> NOTE: Resolving any missing task queue dependencies
> ERROR: Nothing RPROVIDES 'ncurses-libtinfo' (but 
> /msp-lpggp21/lmhatle/build-1/layers/oe-core/meta/recipes-core/images/core-image-minimal.bb 
> RDEPENDS on or otherwise requires it)
> NOTE: Runtime target 'ncurses-libtinfo' is unbuildable, removing...
> Missing or unbuildable dependency chain was: ['ncurses-libtinfo']
> ERROR: Required build target 'core-image-minimal' has no buildable providers.
> Missing or unbuildable dependency chain was: ['core-image-minimal', 
> 'ncurses-libtinfo']
> 
> with the patch applied it completes successfully.
> 
> Reproducer:
> 
> Add to conf/local.conf
> 
> IMAGE_INSTALL_append = " ncurses-libtinfo"
> 
> bitbake core-image-minimal


Fair enough. Can we at least match the pattern do_split_packages uses,
i.e.:

PACKAGES_DYNAMIC = "^${PN}-lib.*"

I'm a little paranoid about adding wildcards like ${PN}-* as the
potential for namespace problems is not insignificant, particularly if
you know the horrible things bitbake does with this behind the
scenes :/.

Cheers,

Richard