[OE-core] [PATCH 1/2] hicolor-icon-theme: keep inherited dependencies

[Eric Bénard]

Hi Ross,

Le Thu, 30 May 2013 12:32:30 +0200,
Eric Bénard <eric at eukrea.com> a écrit :

> Le Thu, 30 May 2013 09:32:38 +0100,
> "Burton, Ross" <ross.burton at intel.com> a écrit :
> 
> > On 30 May 2013 09:09, Martin Jansa <martin.jansa at gmail.com> wrote:
> > > Doesn't it depend now on something which isn't allarch? IIRC gnome.bbclass
> > > brings gconf.
> > 
> > gnome.bbclass is an abomination and should be gutted.  Yes, this will
> > mean the build dependencies are massive, and I can't see why this
> > recipe needs gnome.bbclass.  Then again it doesn't need gtk-icon-cache
> > either as it doesn't actually have any icons in.  I'd be interested in
> > seeing a buildhistory-diff between the current recipe and one with
> > both inherit gnome and DEPENDS="" removed.
> > 
> when  removing gnome I get the following error at install :
> DEBUG: Executing shell function do_install
> install: cannot create regular file
> `/scratch/setup-scripts/build/tmp-defaultsetup-eglibc-eglibc/work/all-oe-li\
> nux/hicolor-icon-theme/0.12-r1/image//usr/share/icons/hicolor': No such
> file or directory
> 
turning on the brain and fixing do_install, the diff between original et
new (without gnome and DEPENDS="") is :

packages/all-oe-linux/hicolor-icon-theme/hicolor-icon-theme:
pkg_postinst cleared:
packages/all-oe-linux/hicolor-icon-theme/hicolor-icon-theme: pkg_postrm
cleared:

So that seems the right thing to do don't you think ?

Eric