[OE-core] [PATCH 2/2] sanity.bbclass: check that TMPDIR is not located on nfs
Richard Purdie
richard.purdie at linuxfoundation.org
Fri Nov 1 10:40:24 UTC 2013
On Sat, 2013-11-02 at 01:26 +0800, Robert Yang wrote:
> There would be some unexpected errors when the whole TMPDIR is located
> on nfs, so add a test for it in sanity.bbclass.
>
> Note:
> The better way to get the filesystem id should be get f_fsid from struct
> statvfs, but there is no f_fsid in os.stat() or os.statvfs(), so we use
> 'stat -f -c "%t"' here.
>
> [YOCTO #5442]
>
> Signed-off-by: Robert Yang <liezhi.yang at windriver.com>
> ---
> meta/classes/sanity.bbclass | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
Why does this need to run every build? It doesn't so don't do that
please.
Cheers,
Richard
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index c4827f4..7517120 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -198,6 +198,21 @@ def check_path_length(filepath, pathname, limit):
> return "The length of %s is longer than 410, this would cause unexpected errors, please use a shorter path.\n" % pathname
> return ""
>
> +def get_filesystem_id(path):
> + status, result = oe.utils.getstatusoutput("stat -f -c '%s' %s" % ("%t", path))
> + if status == 0:
> + return result
> + else:
> + bb.warn("Can't get the filesystem id of: %s" % path)
> + return None
> +
> +# Check that the path isn't located on nfs.
> +def check_not_nfs(path, name):
> + # The nfs' filesystem id is 6969
> + if get_filesystem_id(path) == "6969":
> + return "The %s can't be located on nfs.\n" % name
> + return ""
> +
> def check_connectivity(d):
> # URI's to check can be set in the CONNECTIVITY_CHECK_URIS variable
> # using the same syntax as for SRC_URI. If the variable is not set
> @@ -672,6 +687,9 @@ def check_sanity_everybuild(status, d):
> # The length of TMPDIR can't be longer than 410
> status.addresult(check_path_length(tmpdir, "TMPDIR", 410))
>
> + # Check that TMPDIR isn't located on nfs
> + status.addresult(check_not_nfs(tmpdir, "TMPDIR"))
> +
> def check_sanity(sanity_data):
> import subprocess
>
More information about the Openembedded-core
mailing list