[OE-core] [PATCH] makedevs: fix return error value when input invalid arguments

Richard Purdie richard.purdie at linuxfoundation.org
Tue Nov 5 08:39:08 UTC 2013


On Tue, 2013-11-05 at 16:34 +0800, Lu Chong wrote:
> There is no function to implement "-q" and "--squash" in source 
> code(makedevs.c).
> I also checked in busybox, but I didn't find the function.
> So, may I need to add this function? or remove this options of help 
> information.

I kind of guessed this. These kind of details need to be mentioned in
the commit message. Its not good enough to say what changed, you also
need to say why.

Cheers,

Richard

> Best Regards
> Chong
> 
> On 11/04/2013 07:40 PM, Richard Purdie wrote:
> > On Mon, 2013-11-04 at 16:41 +0800, Chong.Lu at windriver.com wrote:
> >> From: Lu Chong <Chong.Lu at windriver.com>
> >>
> >> Remove "-q" and "--squash" options of help information.
> > Why are we removing this?
> >
> > Cheers,
> >
> > Richard
> >
> >
> >
> >
> 





More information about the Openembedded-core mailing list