[OE-core] lib/oe/sstatesig: Ensure packagegroups don't continually rebuild
Otavio Salvador
otavio at ossystems.com.br
Fri Nov 8 11:55:12 UTC 2013
On Thu, Nov 7, 2013 at 8:57 PM, Richard Purdie
<richard.purdie at linuxfoundation.org> wrote:
> On Thu, 2013-11-07 at 13:58 -0200, Otavio Salvador wrote:
>> On Wed, Nov 6, 2013 at 9:42 PM, Richard Purdie
>> <richard.purdie at linuxfoundation.org> wrote:
>> > On Wed, 2013-11-06 at 16:51 -0200, Otavio Salvador wrote:
>> >> On Tue, Nov 5, 2013 at 8:15 PM, Richard Purdie
>> >> <richard.purdie at linuxfoundation.org> wrote:
>> >> > packagegroups are allarch and shouldn't change depending on the target
>> >> > or machine selected. In general they should have good stable namespaces
>> >> > for their dependencies. As such we can exclude them from rebuilding when
>> >> > dependency checksums change.
>> >> >
>> >> > Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
>> >>
>> >> What about machine-base and core-boot? this may change depending on machine.
>> >
>> > Those already get marked as machine specific. I'd not expect
>> > dependencies to be changing package names there for example so I'm not
>> > sure this is an issue.
>>
>> In:
>>
>> + def isPackageGroup(fn):
>> + inherits = " ".join(dataCache.inherits[fn])
>> + return "packagegroup.bbclass" in inherits
>>
>> We must check PACKAGE_ARCH, no?
>
> No. The fact they're marked as MACHINE_ARCH ensures they change when
> they need to, we don't need sstate to do that as well.
Fine :)
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
More information about the Openembedded-core
mailing list