[OE-core] [PATCH 1/1] sanity.bbclass: check for validity of TMPDIR

[ChenQi]

On 11/15/2013 02:01 AM, Saul Wold wrote:
> On 11/14/2013 07:49 AM, Mark Hatle wrote:
>> On 11/14/13, 7:42 AM, Phil Blundell wrote:
>>> On Thu, 2013-11-14 at 06:27 -0700, Gary Thomas wrote:
>>>> Also, is "-" actually valid?  I seem to recall having problems when
>>>> my build
>>>> tree had the hyphen ("-") in the path.
>>>
>>> Paths with "-" in certainly work for me.  If there are any recipes 
>>> which
>>> break in that situation then we should just fix them.
>>
>> We found an issue with paths that -start- with a '-', there are
>> apparently many places where paths are passed into various shell, and
>> the initial '-' can be read as an argument identifier.
>>
>
> I think that I saw an email talking about "-D" in the TMPDIR caused 
> some some recipes to pick that up as a CFLAG define and cause problems
>
> Sau!
>

Yes. It's actually caused by the following statement in subversion-native.
./build/ac-macros/neon.m4: SVN_NEON_INCLUDES=[`$PKG_CONFIG neon --cflags 
| $SED -e 's/-D[^ ]*//g'`]
./build/ac-macros/neon.m4: SVN_NEON_INCLUDES=[`$neon_config --cflags | 
$SED -e 's/-D[^ ]*//g'`]

And there's a bug filed for it. 
https://bugzilla.yoctoproject.org/show_bug.cgi?id=5458

Best Regards,
Chen Qi

>>> OE already has quite a range of baroque restrictions on what sort of
>>> TMPDIR you are allowed to use (no nfs, no symlinks in the path, no
>>> spaces in the name) and every new prohibition represents a loss in
>>> usability.  This patch as proposed already forbids a whole range of
>>> characters, including things like "+", and I think that disallowing "-"
>>> as well would be a step too far.
>>
>> I don't believe Qi Chen sent it to the list, but we built path names
>> with all of the special characters and tried to run builds.  The
>> specific list is based on the results of those tests.  The other items
>> are already broken, and we're trying to be explicit with this for end
>> users.  (Note, it's really the TMPDIR that matters.. the 'build'
>> directory is a lot more flexible.)
>>
>> --Mark
>>
>>> p.
>>>
>>>
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core at lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core at lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>