[OE-core] [PATCH 2/2] kernel.bbclass: Call make with correct variables in kernelscripts_sstate_postinst

[Bruce Ashfield]

On Tue, Nov 19, 2013 at 12:46 PM, Richard Purdie
<richard.purdie at linuxfoundation.org> wrote:
> On Tue, 2013-11-19 at 12:41 -0500, Bruce Ashfield wrote:
>> On Tue, Nov 19, 2013 at 12:37 PM, Mike Crowe <mac at mcrowe.com> wrote:
>> > Ensure that the environment variable and command line arguments that are
>> > used when calling make in kernel_do_compile are used in
>> > kernelscripts_sstate_postinst.
>>
>> What issue was this causing for you ? The scripts are native, and hence
>> should just be using the build machines compiler, linker and don't need
>> the kernel args.
>>
>> So I'm not convinced that we need this patch, without seeing a tangible
>> issue that was triggered.
>
> I think for some arches at least, something targetish is being cleaned
> and then needing to be rebuilt.

Right. I suppose that if you are installing a mips->mips compiler, then the
target toolchain is required. That really wasn't the intention of this change,
so it likely isn't properly restricted to the native build case (Where native
is a x86 development machine).

But with Phil pointing out the module.bbclass 'make scripts' code again,
I'd like to figure out why it wasn't working for the original bug report and try
to drop all of this mess.

Bruce

>
> I don't want to have to add dependencies for the toolchain so we need to
> look into this further.
>
> Mike: which arch was this on and do you have the compile error?
>
> Cheers,
>
> Richard
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"