[OE-core] [PATCH 1/1] image.bbclass: depends on virtual/kernel

[Martin Jansa]

On Fri, Nov 22, 2013 at 01:39:02PM +0800, Qi.Chen at windriver.com wrote:
> From: Chen Qi <Qi.Chen at windriver.com>
> 
> Add 'virtual/kernel' to DEPENDS in image.bbclass so that the kernel
> can get built by default. Otherwise, the kernel will not get built
> unless it's required by other packages like v86d. As a result, if
> we build 'core-image-minimal' for qemumips, the kernel is not built,
> and we have 'bitbake linux-yocto' before we can use runqemu to start
> the target.

Even when it's not really build time requirement for images I understand
the scenario above and this seems like better place than packagegroup
where it was before.

My only concern is small initramfs images like
meta-initramfs/recipes-bsp/images/initramfs-kexecboot-image.bb:inherit image

which could in turn be DEPENDS of real virtual/kernel causing circular
dependency.

> 
> Signed-off-by: Chen Qi <Qi.Chen at windriver.com>
> ---
>  meta/classes/image.bbclass |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index bc60f0d..ccb6bf3 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -10,7 +10,7 @@ inherit gzipnative
>  
>  LICENSE = "MIT"
>  PACKAGES = ""
> -DEPENDS += "${MLPREFIX}qemuwrapper-cross ${MLPREFIX}depmodwrapper-cross"
> +DEPENDS += "${MLPREFIX}qemuwrapper-cross ${MLPREFIX}depmodwrapper-cross virtual/kernel"
>  RDEPENDS += "${PACKAGE_INSTALL} ${LINGUAS_INSTALL}"
>  RRECOMMENDS += "${PACKAGE_INSTALL_ATTEMPTONLY}"
>  
> -- 
> 1.7.9.5
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20131122/91d05b3d/attachment-0002.sig>