[OE-core] [PATCH] makedevs: Do not return error if the fifo exisits
Mark Hatle
mark.hatle at windriver.com
Tue Oct 1 17:01:17 UTC 2013
On 10/1/13 11:51 AM, Saul Wold wrote:
> This ensures that makedevs will not cause image creation failures
> when it encounters a pipe (fifo) that exists from a previous image.
> The other file/device creation code either ignore this error or check
> for file type.
>
> [YOCTO #5288]
>
> Signed-off-by: Saul Wold <sgw at linux.intel.com>
> ---
> meta/recipes-devtools/makedevs/makedevs-1.0.0/makedevs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/makedevs/makedevs-1.0.0/makedevs.c b/meta/recipes-devtools/makedevs/makedevs-1.0.0/makedevs.c
> index 5d2c45b..7b0487f 100644
> --- a/meta/recipes-devtools/makedevs/makedevs-1.0.0/makedevs.c
> +++ b/meta/recipes-devtools/makedevs/makedevs-1.0.0/makedevs.c
> @@ -274,7 +274,7 @@ static void add_new_file(char *name, char *path, unsigned long uid,
> static void add_new_fifo(char *name, char *path, unsigned long uid,
> unsigned long gid, unsigned long mode)
> {
> - if (mknod(path, mode, 0))
> + if (mknod(path, mode, 0) && errno != EEXIST)
> error_msg_and_die("%s: file can not be created with mknod!", path);
> chown(path, uid, gid);
> // printf("File: %s %s UID: %ld GID: %ld MODE: %04lo\n",
>
Ya, I'm happy with this. It avoids recreating it if it exists.. no error.
No idea if a warning is reasonable in this case, but I'm happy with the change.
--Mark
More information about the Openembedded-core
mailing list