[OE-core] [dylan, master][PATCH] autotools.bbclass: Fix race with sed-native

Richard Tollerton rich.tollerton at ni.com
Tue Oct 8 02:55:25 UTC 2013


sgw at linux.intel.com writes:

>> diff --git a/meta/classes/autotools.bbclass b/meta/classes/autotools.bbclass
>> index 66c0f5d..2bb2aa3 100644
>> --- a/meta/classes/autotools.bbclass
>> +++ b/meta/classes/autotools.bbclass
>> @@ -7,17 +7,25 @@ def autotools_dep_prepend(d):
>>
>>       if pn in ['autoconf-native', 'automake-native', 'help2man-native']:
>>           return deps
>> -    deps += 'autoconf-native automake-native '
>> +    deps += 'autoconf-native automake-native gnu-config-native '
>>
> You don't mention anything about this change.

This might be a moot topic, but maybe I did miss something here:

I thought it was implied in the “light refactoring”. In the original
code, 'gnu-config-native ' would have always been appended by this point
in the code. I thought the "if ...: return deps" idiom would greatly
simplify this function, but in order to use it, 'gnu-config-native '
needs to be appended before each return. So just append it here.

> Sau!


-- 
Richard Tollerton <rich.tollerton at ni.com>



More information about the Openembedded-core mailing list