[OE-core] FILESPATH has unnecessary null element appended to FILESOVERRIDES

[Robert P. J. Day]

  puttering around with FILESEXTRAPATHS and generated the following
output to demonstrate how FILESPATH is created:

$ bb show -r jpeg FILESPATH | tr ':' '\n'
Parsing recipes..done.
# FILESPATH=${@base_set_filespath(["${FILE_DIRNAME}/${BP}", "${FILE_DIRNAME}/${BPN}", "${FILE_DIRNAME}/files"], d)}
FILESPATH="/home/rpjday/oe/dist/layers/oe-core/meta/recipes-core/jpeg/jpeg-8d/arm
/home/rpjday/oe/dist/layers/oe-core/meta/recipes-core/jpeg/jpeg-8d/armv7a
/home/rpjday/oe/dist/layers/oe-core/meta/recipes-core/jpeg/jpeg-8d/beagleboard
/home/rpjday/oe/dist/layers/oe-core/meta/recipes-core/jpeg/jpeg-8d/
/home/rpjday/oe/dist/layers/oe-core/meta/recipes-core/jpeg/jpeg-8d/
/home/rpjday/oe/dist/layers/oe-core/meta/recipes-core/jpeg/jpeg/arm
/home/rpjday/oe/dist/layers/oe-core/meta/recipes-core/jpeg/jpeg/armv7a
/home/rpjday/oe/dist/layers/oe-core/meta/recipes-core/jpeg/jpeg/beagleboard
/home/rpjday/oe/dist/layers/oe-core/meta/recipes-core/jpeg/jpeg/
/home/rpjday/oe/dist/layers/oe-core/meta/recipes-core/jpeg/jpeg/
/home/rpjday/oe/dist/layers/oe-core/meta/recipes-core/jpeg/files/arm
/home/rpjday/oe/dist/layers/oe-core/meta/recipes-core/jpeg/files/armv7a
/home/rpjday/oe/dist/layers/oe-core/meta/recipes-core/jpeg/files/beagleboard
/home/rpjday/oe/dist/layers/oe-core/meta/recipes-core/jpeg/files/
/home/rpjday/oe/dist/layers/oe-core/meta/recipes-core/jpeg/files/"
$

  as you can see, each base filespath generates *two* identical empty
overrides simply because, first:

$ bb show -r jpeg FILESOVERRIDES
Parsing recipes..done.
# FILESOVERRIDES=${TRANSLATED_TARGET_ARCH}:${MACHINEOVERRIDES}:${DISTROOVERRIDES}
FILESOVERRIDES="arm:armv7a:beagleboard:"
$

note the *already* empty override at the end because of empty
DISTROOVERRIDES. at which point, in utils.bbclass, there's this:

def base_set_filespath(path, d):
    filespath = []
    extrapaths = (d.getVar("FILESEXTRAPATHS", True) or "")
    # Don't prepend empty strings to the path list
    if extrapaths != "":
        path = extrapaths.split(":") + path
    # The ":" ensures we have an 'empty' override    <---- THERE
    overrides = ((d.getVar("FILESOVERRIDES", True) or "") + ":").split(":")
    for p in path:
        if p != "":
            for o in overrides:
                filespath.append(os.path.join(p, o))
    return ":".join(filespath)

which adds *another* empty override even when one is already there.

  doesn't hurt, of course, just superfluous. i'll leave it to someone
else to decide if it's worth adjusting.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================