[OE-core] [PATCH V2 2/2] screen: add pkg_postinst to register entry to /etc/shells

Phil Blundell pb at pbcl.net
Thu Oct 17 10:11:51 UTC 2013


On Thu, 2013-10-17 at 18:03 +0800, Ming Liu wrote:
> +pkg_postinst_${PN} () {
> +	touch $D${sysconfdir}/shells
> +	grep -q "${bindir}/screen" $D${sysconfdir}/shells || echo ${bindir}/screen >> $D${sysconfdir}/shells
> +}

Is that "touch" really desirable?  It seems as though screen ought not
really to be creating /etc/shells if it isn't there already, and
probably ought not to be updating the timestamp if it isn't actually
changing the file either.

p.




More information about the Openembedded-core mailing list