[OE-core] [PATCH 3/4] strace: replace += with _append for appending to OVERRIDES variables

[Martin Jansa]

On Sun, Oct 20, 2013 at 06:48:31PM +0800, Ming Liu wrote:
> In some cases, it's unfit to use "+=" in a conditional appending, we would
> end up with the variable being set rather than being appended, which is not
> it mean to.
> 
> Signed-off-by: Ming Liu <ming.liu at windriver.com>
> ---
>  meta/recipes-devtools/strace/strace_4.8.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/strace/strace_4.8.bb b/meta/recipes-devtools/strace/strace_4.8.bb
> index 79a4ad7..aad53b7 100644
> --- a/meta/recipes-devtools/strace/strace_4.8.bb
> +++ b/meta/recipes-devtools/strace/strace_4.8.bb
> @@ -19,7 +19,7 @@ inherit autotools ptest
>  RDEPENDS_${PN}-ptest += "make"
>  
>  PACKAGECONFIG_class-target ?= "libaio"
> -PACKAGECONFIG_class-target += "${@base_contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}"
> +PACKAGECONFIG_append_class-target = " ${@base_contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}"

Doesn't using _append make it unnecessary harder to changed default value
in .bbappend?

Why not use
PACKAGECONFIG_class-target ?= "libaio ${@base_contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}"
at least in this case?

Thanks

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20131020/543b4c21/attachment-0002.sig>