[OE-core] [PATCH 1/5] gnome: set UNKNOWN_CONFIGURE_WHITELIST

Otavio Salvador otavio at ossystems.com.br
Mon Oct 28 17:12:35 UTC 2013


On Mon, Oct 28, 2013 at 3:08 PM, Burton, Ross <ross.burton at intel.com> wrote:
> On 28 October 2013 15:59, Otavio Salvador <otavio at ossystems.com.br> wrote:
>> On Mon, Oct 28, 2013 at 12:33 PM, Ross Burton <ross.burton at intel.com> wrote:
>>> This class passes --disable-introspection to everything that inherits it but not
>>> all GNOME modules support introspection, so add that option to the
>>> unknown-configure-options sanity test whitelist.
>>>
>>> Signed-off-by: Ross Burton <ross.burton at intel.com>
>>
>> I understand the change but it does not match with the commit log.
>
> How so?
>
> -EXTRA_OECONF += "--enable-introspection=no"
> +EXTRA_OECONF += "--disable-introspection"
>
> This is a semantically identical change as far as autoconf is
> concerned, that makes the whitelist clearer.

For autoconf it is but for a human it is not. Please add this to the commit log.

> +UNKNOWN_CONFIGURE_WHITELIST += "--disable-introspection"
>
> This is the unknown configure options whitelist.
>
> Ross



-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750



More information about the Openembedded-core mailing list