[OE-core] [PATCH 4/4] libfm: allow build with automake-1.14

[Marko Lindqvist]

On 29 October 2013 02:35, Khem Raj <raj.khem at gmail.com> wrote:
> Marko
>
> On Fri, Oct 25, 2013 at 12:39 AM, Marko Lindqvist <cazfi74 at gmail.com> wrote:
>> Do not consider automake warnings about future incompatibility
>> errors.
>
> hmmm so disabling Werror is working around and I consider it degradation
> in code quality, is there any alternative ?

 I agree on principle. That's why I wouldn't even consider submitting
this to upstream, as future versions should handle this correctly. I
think it's ok for us to patch the current version this way, as the
warnings are about the future only.

> may be fix the code itself to not
> generate the warning at all ?

 That's something that (upstream) must do anyway before automake-2.0
comes out and turns these warnings in to errors. I'm not going to
figure these out for every upstream that has such a problem. When we
were preparing for automake-1.13, I submitted fixes to nearly 100
upstreams. While I usually am happy to fix the problems I encounter,
I'm not ready to make anything like that again. I'll leave proper
fixes for these problems for upstreams to make.


 - ML